http: remove unnecessary util._extend()

[jonathanong]

on a mission to remove all instances of util._extend() and I found this. AFAIK, this is unnecessary. 6100228#diff-1c0f1c434b17b7f8795d44a51a14320aR31

/cc @bnoordhuis

[micnic]

LGTM

> Array.isArray(require('_http_common').methods);
true

so no need to use util._extend()

[bnoordhuis]

The methods array is used inside the http parser guts. That's the reason it's cloned, because accidentally (or intentionally) modifying it is bound to break things. I would just leave it as it is.

[jonathanong]

But sorting makes a clone...

[bnoordhuis]

Nuh-uh. :-)

$ iojs -p 'var a = []; a === a.sort()'
true

[jonathanong]

Waaaaaaa is it because no sorting took place?

[charmander]

No, sort always sorts an array in place. .slice might be better than _extend, though.

[jonathanong]

@charmander agreed. updated

[Qard]

Landed in 3e67d7e

[jonathanong]

👍