Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update DCO to v1.1 #6353

Closed
wants to merge 1 commit into from
Closed

doc: Update DCO to v1.1 #6353

wants to merge 1 commit into from

Conversation

williamkapke
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Description of change

See: nodejs/TSC#92

@claudiorodriguez claudiorodriguez added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Apr 23, 2016
@Fishrock123
Copy link
Contributor

@mikeal Didn't we discuss something CLA-ish in some meeting because of legal crap? Would that invalidate this?

@mikeal
Copy link
Contributor

mikeal commented Apr 24, 2016

@Fishrock123 no, they are entirely separate. The CLA discussions are about how to provide patent protection, they aren't about copyright, which is what the DCO is about.

@jasnell
Copy link
Member

jasnell commented Apr 25, 2016

LGTM

@williamkapke williamkapke mentioned this pull request Apr 27, 2016
Closed
2 tasks
@williamkapke
Copy link
Contributor Author

williamkapke commented Apr 29, 2016 •
edited
Loading

I think this is ready to be merged. This will trickle down to node-chakracore when it is. See: nodejs/node-chakracore#63

@jasnell
Copy link
Member

jasnell commented May 17, 2016

@nodejs/ctc ... any objections to this?

@rvagg
Copy link
Member

rvagg commented May 17, 2016

:shipit: lgtm

@mhdawson
Copy link
Member

LGTM, but do we have any requirements to give contributors a heads up when this change is adopted ? For example when adopted by a working group ?

@indutny
Copy link
Member

indutny commented May 17, 2016

LGTM

@mikeal
Copy link
Contributor

mikeal commented May 17, 2016

LGTM, but do we have any requirements to give contributors a heads up when this change is adopted ? For example when adopted by a working group ?

I don't think so, the only material change is the reference to Signoffs which we've done for quite a while and has been documented in the contribution guidelines for at least a year.

@williamkapke
Copy link
Contributor Author

There are several LGTMs on this. Can someone with access hit Merge for me? :)

jasnell pushed a commit that referenced this pull request May 20, 2016
@williamkapke @jasnell
doc: Update DCO to v1.1
7c3e920 
PR-URL: #6353
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Mikeal Rogers <mikeal.rogers@gmail.com>
@jasnell
Copy link
Member

jasnell commented May 20, 2016

Landed in 7c3e920

@jasnell jasnell closed this May 20, 2016
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
@williamkapke @Fishrock123
doc: Update DCO to v1.1
46ad7ad 
PR-URL: #6353
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Mikeal Rogers <mikeal.rogers@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@williamkapke @rvagg
doc: Update DCO to v1.1
565d4ca 
PR-URL: #6353
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Mikeal Rogers <mikeal.rogers@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 2, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jun 3, 2016
@williamkapke
doc: Update DCO to v1.1
1b6e2fe 
PR-URL: #6353
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Mikeal Rogers <mikeal.rogers@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@williamkapke
doc: Update DCO to v1.1
fbf95dd 
PR-URL: #6353
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Mikeal Rogers <mikeal.rogers@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@williamkapke
doc: Update DCO to v1.1
18044ae 
PR-URL: #6353
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Mikeal Rogers <mikeal.rogers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@williamkapke @Fishrock123 @mikeal @jasnell @rvagg @mhdawson @indutny @MylesBorins @claudiorodriguez