Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use libuv's refcounting directly #6395

Merged
merged 3 commits into from
Apr 27, 2016
Merged

src: use libuv's refcounting directly #6395

merged 3 commits into from
Apr 27, 2016

Commits on Apr 27, 2016

  1. src: use libuv's refcounting directly 

    Don't implement an additional reference counting scheme on top of libuv.
Libuv is the canonical source for that information so use it directly.

PR-URL: nodejs#6395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    cad1a62 View commit details
    Browse the repository at this point in the history

  2. src: simplify handlewrap state tracking logic 

    This also updates the tests to expect that a closed handle has no
reference count.

PR-URL: nodejs#6395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    a58d483 View commit details
    Browse the repository at this point in the history

  3. test: check that 2nd handle.close() call is a nop 

    Verify that a second call to handle.close() is a no-op.

PR-URL: nodejs#6395
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Apr 27, 2016
    Configuration menu
    Copy the full SHA
    4282405 View commit details
    Browse the repository at this point in the history