build: unbreak -prof, disable PIE on OS X #6453
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7") unwittingly turned on new ASLR features that make `-prof` unusable for profiling C++ code, breaking `test/parallel/test-tick-processor.js` in the process. Build with `-Wl,-no_pie` for now. Fixes: nodejs#5903
bnoordhuis
added
build
|
LGTM |
|
LGTM pending CI. Confirmed locally that it addresses the issue. |
|
CI is green! 🎉 I know we just had a conversation about not rushing PRs and stuff, but to the extent that my opinion matters, I think this one warrants expediting. Broken CI means people mistrust it even after it's fixed and then ignore additional failures, and this seems like a small and easy-to-back-out change. |
|
LGTM and go ahead if you want to land this. |
jasnell
pushed a commit
that referenced
this pull request
Apr 29, 2016
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7") unwittingly turned on new ASLR features that make `-prof` unusable for profiling C++ code, breaking `test/parallel/test-tick-processor.js` in the process. Build with `-Wl,-no_pie` for now. Fixes: #5903 PR-URL: #6453 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in a5012a0 to get back to green CI. @bnoordhuis ... I've personally had to set this for a couple of other projects. What are the particular drawbacks for leaving this on indefinitely? (sorry, not that familiar with ASLR) Should be open a tracking issue to pull this back out at a later date? |
Fishrock123
pushed a commit
that referenced
this pull request
May 4, 2016
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7") unwittingly turned on new ASLR features that make `-prof` unusable for profiling C++ code, breaking `test/parallel/test-tick-processor.js` in the process. Build with `-Wl,-no_pie` for now. Fixes: #5903 PR-URL: #6453 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced May 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 204f3a8 ("build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7")
unwittingly turned on new ASLR features that make
-profunusable forprofiling C++ code, breaking
test/parallel/test-tick-processor.jsinthe process. Build with
-Wl,-no_piefor now.Fixes: #5903
CI: https://ci.nodejs.org/job/node-test-pull-request/2420/