-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: added note warning about change to console.endTime() #6454
Conversation
@@ -230,6 +230,11 @@ console.timeEnd('100-elements'); | |||
// prints 100-elements: 225.438ms | |||
``` | |||
|
|||
*Note: As of node v6.0.0, timeEnd() deletes the timer to avoid leaking it. On |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use Node.js v6.0.0
here please?
Maybe also instead of "timeEnd()", do console.timeEnd()
Thanks for the PR @ben-page! I made a few comments. Let me know if you have any questions. /cc @nodejs/documentation |
LGTM with nits addressed |
LGTM with @evanlucas nits addressed. Thx. |
Unintended functionality was removed from console.endTime by nodejs#3562. Prior to that, you could call console.endTime multiple times for the same label.
b05db6f
to
dad5c2c
Compare
Thanks for the feedback. I made the changes. |
LGTM |
1 similar comment
LGTM |
Unintended functionality was removed from console.endTime by #3562. Prior to that, you could call console.endTime multiple times for the same label. PR-URL: #6454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Landed in 541965f |
Unintended functionality was removed from console.endTime by #3562. Prior to that, you could call console.endTime multiple times for the same label. PR-URL: #6454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Unintended functionality was removed from console.endTime by nodejs#3562. Prior to that, you could call console.endTime multiple times for the same label. PR-URL: nodejs#6454 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
Checklist
Affected core subsystem(s)
doc
Description of change
I added a note warning about a change to console.endTime(). Prior to #3562, you could call console.endTime multiple times for the same label. This was unintended functionality, but the change needed to be documented.
Related Issue: #6452