Revert "handle_wrap: IsRefed -> Unrefed, no isAlive check" #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
the
lib / src
nodejs-github-bot
added
the
c++
4 tasks
|
and here's some proof (kinda) that it actually works (reasonably): #6381 (comment) |
|
Can you please add some explanation in the commit message about why would be reverted. |
Fishrock123
force-pushed
the
revert-9bb5a5e
branch
from
e19c5dd
to
00cf1f4
Compare
|
@jasnell done, ptal |
Fishrock123
force-pushed
the
revert-9bb5a5e
branch
2 times, most recently
from
cd80f4b
to
2688e45
Compare
|
Thank you. CI is green. LGTM but want @bnoordhuis and @trevnorris to sign off as well. |
|
ping @bnoordhuis & @trevnorris |
|
Quick LGTM. Can we rename them now to |
|
@bnoordhuis I may as well do that in a second commit here then.. |
Fishrock123
force-pushed
the
revert-9bb5a5e
branch
from
2688e45
to
54bc12e
Compare
|
updated ptal.. |
|
2nd commit LGTM2. |
|
attempting to ping @trevnorris again |
|
LGTM. Second commit enough to warrant another CI run? |
|
@trevnorris Yeah good call: https://ci.nodejs.org/job/node-test-pull-request/2593/ |
|
CI is green, landing. |
This reverts commit 9bb5a5e. This API is not suitable because it depended on being able to potentially access the handle's flag after the handle was already cleaned up. Since this is not actually possible (obviously, oops) this newer API no longer makes much sense, and the older API is more suitable. API comparison: IsRefed -> Has a strong reference AND is alive. (Deterministic) Unrefed -> Has a weak reference OR is dead. (Less deterministic) Refs: nodejs#6395 Refs: nodejs#6204 Refs: nodejs#6401 Refs: nodejs#6382 Fixes: nodejs#6381 PR-URL: nodejs#6546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Conflicts: src/handle_wrap.cc test/parallel/test-handle-wrap-isrefed-tty.js test/parallel/test-handle-wrap-isrefed.js
Rename slightly to HasRef() at bnoordhuis’ request. Better reflects what we actually do for this check. Refs: nodejs#6395 Refs: nodejs#6204 Refs: nodejs#6401 Refs: nodejs#6382 Refs: nodejs#6381 PR-URL: nodejs#6546 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Fishrock123
force-pushed
the
revert-9bb5a5e
branch
from
54bc12e
to
fe4837a
Compare
|
For posterity, landing this requires this commit chain:
|
2 tasks
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
This reverts commit 9bb5a5e. This API is not suitable because it depended on being able to potentially access the handle's flag after the handle was already cleaned up. Since this is not actually possible (obviously, oops) this newer API no longer makes much sense, and the older API is more suitable. API comparison: IsRefed -> Has a strong reference AND is alive. (Deterministic) Unrefed -> Has a weak reference OR is dead. (Less deterministic) Refs: #6395 Refs: #6204 Refs: #6401 Refs: #6382 Fixes: #6381 PR-URL: #6546 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Conflicts: src/handle_wrap.cc test/parallel/test-handle-wrap-isrefed-tty.js test/parallel/test-handle-wrap-isrefed.js
|
@Fishrock123 Added dont-land label. please feel free to make a change if that was incorrect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
handle_wrap
Description of change
This reverts commit 9bb5a5e.
Refs: #6395
Refs: #6204
Refs: #6401
Refs: #6382
Fixes: #6381
Conflicts:
src/handle_wrap.cc
test/parallel/test-handle-wrap-isrefed-tty.js
test/parallel/test-handle-wrap-isrefed.js
My own stupidity for changing this. cc @bnoordhuis, @jasnell, @trevnorris so this can hopefully be landed properly into a release. (Hopefully this week?..)