Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade v8 to 4.1.0.14 #656

Merged
merged 1 commit into from
Jan 29, 2015
Merged

Conversation

bnoordhuis
Copy link
Member

@Fishrock123
Copy link
Contributor

Is this semver-minor?

@piscisaureus
Copy link
Contributor

Does this fix nodejs/node-v0.x-archive#9084 ?

@bnoordhuis
Copy link
Member Author

Is this semver-minor?

No, it's just a bug fix.

Does this fix nodejs/node-v0.x-archive#9084

Unlikely.

@indutny
Copy link
Member

indutny commented Jan 29, 2015

@bnoordhuis what does it fix then? :)

@indutny
Copy link
Member

indutny commented Jan 29, 2015

@Fishrock123 semver patch, I guess

@bnoordhuis
Copy link
Member Author

A buglet in 'use asm' code. Nothing shocking but as I had to upgrade V8 anyway to verify that #648 was still happening with the tip of the 4.1.0.x branch, I figured I might as well file it as a pull request.

@targos
Copy link
Member

targos commented Jan 29, 2015

from https://github.com/v8/v8-git-mirror/releases :

Version 4.1.0.14 (cherry-pick)
Merged d1c1a3c

[turbofan] Fix bit representation of NumberConstant.

Is there an other place to find v8's changelog ?

@indutny
Copy link
Member

indutny commented Jan 29, 2015

LGTM

PR-URL: nodejs#656
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@bnoordhuis bnoordhuis merged commit cbc1262 into nodejs:v1.x Jan 29, 2015
@bnoordhuis bnoordhuis deleted the upgrade-v8 branch January 29, 2015 17:13
@bnoordhuis
Copy link
Member Author

@targos One would normally consult https://github.com/iojs/io.js/blob/v1.x/deps/v8/ChangeLog - except that the V8 team doesn't seem to update it in the 4.1 branch, they just cherry-pick patches from the development branch. :-( git log is probably as good as it's going to get for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants