-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: upgrade v8 to 4.1.0.14 #656
Conversation
Is this |
Does this fix nodejs/node-v0.x-archive#9084 ? |
No, it's just a bug fix.
Unlikely. |
@bnoordhuis what does it fix then? :) |
@Fishrock123 semver patch, I guess |
A buglet in 'use asm' code. Nothing shocking but as I had to upgrade V8 anyway to verify that #648 was still happening with the tip of the 4.1.0.x branch, I figured I might as well file it as a pull request. |
from https://github.com/v8/v8-git-mirror/releases :
Is there an other place to find v8's changelog ? |
LGTM |
PR-URL: nodejs#656 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
e0dc5fe
to
cbc1262
Compare
@targos One would normally consult https://github.com/iojs/io.js/blob/v1.x/deps/v8/ChangeLog - except that the V8 team doesn't seem to update it in the 4.1 branch, they just cherry-pick patches from the development branch. :-( |
R=@indutny