Code

Openssl clientcertengine support2#6569

Code

Closed

joelostrowski wants to merge 17 commits intonodejs:masternodejs/node:masterfrom joelostrowski:openssl-clientcertengine-support2joelostrowski/node:openssl-clientcertengine-support2Copy head branch name to clipboard

+304-24

Commits

Commits on Sep 1, 2016

• implemented clientCertEngine option to allow using openssl client certificate engines with https.request

  joelostrowski

  committed
  498e189

  Copy full SHA for 498e189

• fixed linting

  joelostrowski

  committed
  0c82a37

  Copy full SHA for 0c82a37

• minor cleanup

  joelostrowski

  committed
  f2aab17

  Copy full SHA for f2aab17

• doc: added description of clientCertEngine option

  joelostrowski

  committed
  dbf47ae

  Copy full SHA for dbf47ae

• fixed lint

  joelostrowski

  committed
  9fc1a9a

  Copy full SHA for 9fc1a9a

• fixed c++ spacing

  joelostrowski

  committed
  7b27ab3

  Copy full SHA for 7b27ab3

• refactored common code into a function

  joelostrowski

  committed
  efe5aca

  Copy full SHA for efe5aca

• changes made due to review comments

  joelostrowski

  committed
  2faddc4

  Copy full SHA for 2faddc4

• fixes due to further feedback

  joelostrowski

  committed
  9fea66a

  Copy full SHA for 9fea66a

• added a few more common.mustCall wrappings

  joelostrowski

  committed
  7ce6187

  Copy full SHA for 7ce6187

• minor style changes

  joelostrowski

  committed
  ddeb024

  Copy full SHA for ddeb024

• fixed typo in documentation

  joelostrowski

  committed
  ad9139f

  Copy full SHA for ad9139f

• removed spurious old text that appeared during a merge conflict

  joelostrowski

  committed
  a52d405

  Copy full SHA for a52d405

• updated test to include the extra field in agent name

  joelostrowski

  committed
  e95d204

  Copy full SHA for e95d204

• small fixes after review

  joelostrowski

  committed
  922e5da

  Copy full SHA for 922e5da

• doc: aligned the description of clientCertEngine to be the same everywhere

  joelostrowski

  committed
  249a46b

  Copy full SHA for 249a46b

• minor fixes of style and silence succeeding test

  joelostrowski

  committed
  e72b12b

  Copy full SHA for e72b12b