test: fix test-process-exec-argv flakiness #6575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
mscdex
added
the
child_process
|
LGTM. CI is green except for Jenkins issues on armv8-ubuntu1404. |
|
LGTM |
santigimeno
force-pushed
the
fix_text_process_exec_argv
branch
from
12e8968 to
ed982b1
Compare
|
6000+ runs on test-process-exec-argv on a machine were we'd seen it fail 0.4% of the time without this change so LGTM |
|
By the way, the upcoming libuv release (libuv/libuv#867) contains a fix that quite possibly also resolves this. |
|
@bnoordhuis should this be merged anyway or just wait for the fix? |
|
It would be interesting to find out if it fixes the test but don't let it block you. |
Wait for the `close` event before parsing the child stdout output. Fixes: nodejs#6480 PR-URL: nodejs#6575 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
santigimeno
force-pushed
the
fix_text_process_exec_argv
branch
from
ed982b1 to
80481da
Compare
|
CI green expect unrelated failures: https://ci.nodejs.org/job/node-test-pull-request/2605/ |
|
Landed in dffafde. Thanks! |
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
|
@thealphanerd PR with the backport here: #7128 |
santigimeno
added a commit
to santigimeno/node
that referenced
this pull request
Jun 3, 2016
Wait for the `close` event before parsing the child stdout output. Fixes: nodejs#6480 Ref: nodejs#6575 PR-URL: nodejs#7128 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 4, 2016
Wait for the `close` event before parsing the child stdout output. Fixes: #6480 Ref: #6575 PR-URL: #7128 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Wait for the `close` event before parsing the child stdout output. Fixes: #6480 Ref: #6575 PR-URL: #7128 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Wait for the `close` event before parsing the child stdout output. Fixes: #6480 Ref: #6575 PR-URL: #7128 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
Wait for the
closeevent before parsing the child stdout output.Fixes: #6480
I was able to reproduce the error reported in #6480 in my
OS Xbox. This change fixed the issue.