Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: get rid of sneaky hard tabs in CHANGELOG #6608

Merged
merged 1 commit into from
May 6, 2016
Merged

Conversation

MylesBorins
Copy link
Contributor

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

My editor did something strange. Sorry about that

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 6, 2016
@MylesBorins MylesBorins added the doc Issues and PRs related to the documentations. label May 6, 2016
@cjihrig
Copy link
Contributor

cjihrig commented May 6, 2016

LGTM

My editor did something strange. Sorry about that

PR-URL: #6608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins
Copy link
Contributor Author

landed in 2bceda6

@MylesBorins MylesBorins closed this May 6, 2016
@MylesBorins MylesBorins merged commit 2bceda6 into master May 6, 2016
@MylesBorins MylesBorins deleted the hard-tabs branch May 6, 2016 01:28
MylesBorins pushed a commit that referenced this pull request May 6, 2016
My editor did something strange. Sorry about that

PR-URL: #6608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas
Copy link
Contributor

Marking dont-land-on-v6x since it relies on changelogs for v5 and v4 (which we aren't backporting). If this is not the case, please let me know @thealphanerd. Thanks!

@jasnell
Copy link
Member

jasnell commented May 17, 2016

I'll likely be backporting the changelog updates this week to v5 and v4, just haven't had much opportunity to do so yet.

@evanlucas
Copy link
Contributor

@jasnell ok cool. So am I still good to hold off on this?

@jasnell
Copy link
Member

jasnell commented May 17, 2016

Yeah, I would for now but let's not forget about it.

MylesBorins pushed a commit that referenced this pull request May 18, 2016
My editor did something strange. Sorry about that

PR-URL: #6608
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants