Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc,events: fix a link typo #6640

Closed
wants to merge 1 commit into from
Closed

Conversation

yorkie
Copy link
Contributor

@yorkie yorkie commented May 8, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
  • events
Description of change

I guess someone did change the argument name, but not update the below links. Do we have a way to check the function links?

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 8, 2016
@mscdex mscdex added the events Issues and PRs related to the events subsystem / EventEmitter. label May 8, 2016
@estliberitas
Copy link
Contributor

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented May 9, 2016

LGTM

@yorkie
Copy link
Contributor Author

yorkie commented May 10, 2016

Ping :-)

@evanlucas
Copy link
Contributor

LGTM

@evanlucas
Copy link
Contributor

Landed in 6e9a4ab. Thanks!

@evanlucas evanlucas closed this May 10, 2016
evanlucas pushed a commit that referenced this pull request May 10, 2016
PR-URL: #6640
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@yorkie yorkie deleted the fix/events-doc branch May 10, 2016 11:49
evanlucas pushed a commit that referenced this pull request May 17, 2016
PR-URL: #6640
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants