Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade npm to 3.8.9 #6664

Closed
wants to merge 1 commit into from
Closed

upgrade npm to 3.8.9 #6664

wants to merge 1 commit into from

Conversation

iarna
Copy link
Member

@iarna iarna commented May 10, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

Beyond the usual dependency updates and documentation improvements we saw a number of bug fixes:

  • Using --ignore-scripts now logs to info when it doesn't run something.
  • When packing/publishing, correctly exclude everything in node_modules that are not a part of bundled dependencies. Previously implicitly included files like README and Changelog found in node_modules were being included in the package tarballs.
  • Fixes for handling of file:// URLs on Windows.
  • More consistent handling of local dependencies (that is, when your dep is a local tarball or directory).
  • Previously, shrinkwraps could end up w/o a resolved field sometimes. This fixes that.
  • Fixed an error where non-package modules could crash on Windows.
  • Fixed bad output when using npm view pkgname fieldname to look at specific fields in the package metadata.

And the progress-config test no longer fails if you happened to have set progress in your npmrc.

Changelogs:

r: @zkat
r: @thealphanerd
r: @Fishrock123

@iarna iarna added npm Issues and PRs related to the npm client dependency or the npm registry. dont-land-on-v4.x labels May 10, 2016
@MylesBorins
Copy link
Contributor

MylesBorins commented May 10, 2016 •
edited
Loading

Here's an attempt at a new CI job that runs make test-npm on osx... if this is successful we'll start trying to roll in windows support

edit: left out the link https://ci.nodejs.org/view/All/job/thealphanerd-npm/4/

@iarna
Copy link
Member Author

iarna commented May 10, 2016

3.9.0 is where the Windows test fixes landed, so we'll get those next week. =)

@iarna
Copy link
Member Author

iarna commented May 10, 2016

Our biggest issue with Windows in CI was getting git (and paths to git plumbing) setup correctly.

@MylesBorins
Copy link
Contributor

@iarna I was missing the link. I had created a CI job on the node infra to run the npm test suite as we would normally manually do prior to landing. The hope would be that we can get window support here too.

If we are able to get this testing both on you end prior to making PR's and on our end when those PR's land we'll be in a great spot!

@Fishrock123
Copy link
Contributor

Tests passed locally, lgtm. @thealphanerd Looks like the CI failed though, but I don't think we need to wait on that?

@MylesBorins
Copy link
Contributor

@Fishrock123 not at all, that CI is experimental if tests passed locally for you LGTM

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 10, 2016
@iarna @Fishrock123
deps: upgrade npm to 3.8.9
5c36cfc 
Contains the following three npm releases:
https://github.com/npm/npm/releases/tag/v3.8.7
https://github.com/npm/npm/releases/tag/v3.8.8
https://github.com/npm/npm/releases/tag/v3.8.9

PR-URL: nodejs#6664
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Thanks, landed in 5c36cfc 💥

evanlucas pushed a commit that referenced this pull request May 17, 2016
@iarna @evanlucas
deps: upgrade npm to 3.8.9
bddf413 
Contains the following three npm releases:
https://github.com/npm/npm/releases/tag/v3.8.7
https://github.com/npm/npm/releases/tag/v3.8.8
https://github.com/npm/npm/releases/tag/v3.8.9

PR-URL: #6664
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
evanlucas added a commit that referenced this pull request May 17, 2016
@evanlucas
2016-05-17, Version 6.2.0 (Stable)
9fab6aa 
- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna
  Henningsen) [#6511](#6511)
- **child_process**: use /system/bin/sh on android (Ben Noordhuis)
  [#6745](#6745)
- **deps**:
  - upgrade npm to 3.8.9 (Rebecca Turner)
    [#6664](#6664)
  - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh)
    [#6572](#6572)
  - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    [#6796](#6796)
  - Intl: ICU 57 bump (Steven R. Loomis)
    [#6088](#6088)
- **repl**:
  - copying tabs shouldn't trigger completion (Eugene Obrezkov)
    [#5958](#5958)
  - exports `Recoverable` (Blake Embrey)
    [#3488](#3488)
- **src**: add O_NOATIME constant (Rich Trott)
  [#6492](#6492)
- **src,module**: add --preserve-symlinks command line flag (James M
  Snell) [#6537](#6537)
- **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen)
  [#6683](#6683)
evanlucas added a commit that referenced this pull request May 17, 2016
@evanlucas
2016-05-17, Version 6.2.0 (Stable)
a4705f6 
- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna
  Henningsen) [#6511](#6511)
- **child_process**: use /system/bin/sh on android (Ben Noordhuis)
  [#6745](#6745)
- **deps**:
  - upgrade npm to 3.8.9 (Rebecca Turner)
    [#6664](#6664)
  - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh)
    [#6572](#6572)
  - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    [#6796](#6796)
  - Intl: ICU 57 bump (Steven R. Loomis)
    [#6088](#6088)
- **repl**:
  - copying tabs shouldn't trigger completion (Eugene Obrezkov)
    [#5958](#5958)
  - exports `Recoverable` (Blake Embrey)
    [#3488](#3488)
- **src**: add O_NOATIME constant (Rich Trott)
  [#6492](#6492)
- **src,module**: add --preserve-symlinks command line flag (James M
  Snell) [#6537](#6537)
- **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen)
  [#6683](#6683)

As of this release the 6.X line now includes 64-bit binaries for Linux
on Power Systems running in big endian mode in addition to the existing
64-bit binaries for running in little endian mode.

PR-URL: #6810
evanlucas added a commit that referenced this pull request May 17, 2016
@evanlucas
2016-05-17, Version 6.2.0 (Stable)
26120e2 
- **buffer**: fix lastIndexOf and indexOf in various edge cases (Anna
  Henningsen) [#6511](#6511)
- **child_process**: use /system/bin/sh on android (Ben Noordhuis)
  [#6745](#6745)
- **deps**:
  - upgrade npm to 3.8.9 (Rebecca Turner)
    [#6664](#6664)
  - upgrade to V8 5.0.71.47 (Ali Ijaz Sheikh)
    [#6572](#6572)
  - upgrade libuv to 1.9.1 (Saúl Ibarra Corretgé)
    [#6796](#6796)
  - Intl: ICU 57 bump (Steven R. Loomis)
    [#6088](#6088)
- **repl**:
  - copying tabs shouldn't trigger completion (Eugene Obrezkov)
    [#5958](#5958)
  - exports `Recoverable` (Blake Embrey)
    [#3488](#3488)
- **src**: add O_NOATIME constant (Rich Trott)
  [#6492](#6492)
- **src,module**: add --preserve-symlinks command line flag (James M
  Snell) [#6537](#6537)
- **util**: adhere to `noDeprecation` set at runtime (Anna Henningsen)
  [#6683](#6683)

As of this release the 6.X line now includes 64-bit binaries for Linux
on Power Systems running in big endian mode in addition to the existing
64-bit binaries for running in little endian mode.

PR-URL: #6810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iarna @MylesBorins @Fishrock123