Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc:use proper article #6689

Closed
wants to merge 1 commit into from
Closed

doc:use proper article #6689

wants to merge 1 commit into from

Conversation

anchika
Copy link
Contributor

@anchika anchika commented May 11, 2016 •
edited by Fishrock123
Loading

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Refer the Github issue #6642 #6642

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 11, 2016
@targos
Copy link
Member

targos commented May 11, 2016

LGTM

@thefourtheye
Copy link
Contributor

LGTM. cc @nodejs/documentation

@estliberitas
Copy link
Contributor

LGTM

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 11, 2016
@anchika @Fishrock123
doc: "a" -> "an" in api/documentation.md
000ef89 
Fixes: nodejs#6642
PR-URL: nodejs#6689
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Landed in 000ef89, thanks!

evanlucas pushed a commit that referenced this pull request May 17, 2016
@anchika @evanlucas
doc: "a" -> "an" in api/documentation.md
d962fba 
Fixes: #6642
PR-URL: #6689
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
@anchika
doc: "a" -> "an" in api/documentation.md
8b61f60 
Fixes: #6642
PR-URL: #6689
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
@anchika
doc: "a" -> "an" in api/documentation.md
4ac60fa 
Fixes: #6642
PR-URL: #6689
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@anchika
doc: "a" -> "an" in api/documentation.md
3d820e4 
Fixes: #6642
PR-URL: #6689
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@anchika
doc: "a" -> "an" in api/documentation.md
a7fb99a 
Fixes: #6642
PR-URL: #6689
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@anchika @targos @thefourtheye @estliberitas @Fishrock123 @MylesBorins @nodejs-github-bot