tools,test: make argument linting more stringent #6720
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
test
|
/cc @silverwind |
|
No accompaning rule change? Seems a bit pointless if you don't enforce the style. Note that I'm not really a fan of the alignment at |
|
@silverwind There is a change to |
|
Ah, totally missed that. LGTM. |
| @@ -32,8 +32,7 @@ function checkArgumentAlignment(context, node) { | |||
| 'ArrowFunctionExpression', | |||
| 'CallExpression', | |||
| 'FunctionExpression', | |||
| 'ObjectExpression', | |||
| 'TemplateLiteral' | |||
| 'ObjectExpression' | |||
There was a problem hiding this comment.
Nittiest of nitpicks but if you leave the comma, the diff is one line shorter.
There was a problem hiding this comment.
I'm a supporter of the final-line dangling-comma but don't see it too much in the code base here. Happy to add an instance! And...
...done!
|
LGTM |
The custom linting rule for argument alignment in multi-line function calls previously ignored template strings in an effort to avoid false positives. This isn't really necessary. Enforce for template strings and adjust whitespace in three tests to abide. (Insert "The test abides" joke of your choosing here.)
|
Only CI failure is an unrelated known-flaky (with a possible fix pending in another PR, woot). |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 16, 2016
The custom linting rule for argument alignment in multi-line function calls previously ignored template strings in an effort to avoid false positives. This isn't really necessary. Enforce for template strings and adjust whitespace in three tests to abide. (Insert "The test abides" joke of your choosing here.) PR-URL: nodejs#6720 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in d73e189 |
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
The custom linting rule for argument alignment in multi-line function calls previously ignored template strings in an effort to avoid false positives. This isn't really necessary. Enforce for template strings and adjust whitespace in three tests to abide. (Insert "The test abides" joke of your choosing here.) PR-URL: #6720 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test tools
Description of change
The custom linting rule for argument alignment in multi-line function
calls previously ignored template strings in an effort to avoid false
positives. This isn't really necessary. Enforce for template strings and
adjust whitespace in three tests to abide. (Insert "The test abides"
joke of your choosing here.)