Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: reduce GitHub template verbosity #6801

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented May 17, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Reduce unnecessarily verbose paragraph to a sentence.

/cc @rvagg

@Trott Trott added the doc Issues and PRs related to the documentations. label May 17, 2016
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 17, 2016
@jasnell
Copy link
Member

jasnell commented May 17, 2016

LGTM. (fyi...anything related to these templates that makes them shorter is likely to get an automatic LGTM from me)

@jbergstroem
Copy link
Member

LGTM

1 similar comment
@mscdex
Copy link
Contributor

mscdex commented May 17, 2016

LGTM

@rvagg
Copy link
Member

rvagg commented May 17, 2016

LGTM. (fyi...anything related to these templates that makes them shorter is likely to get an automatic LGTM from me)

ditto, lgtm, cut cut cut

@Fishrock123
Copy link
Contributor

ditto, lgtm, cut cut cut

🔪 🔪 🔪 🔪

@MylesBorins
Copy link
Contributor

LGTM

Trott added a commit to Trott/io.js that referenced this pull request May 20, 2016
Reduce unnecessarily verbose paragraph to a sentence.

PR-URL: nodejs#6801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@Trott
Copy link
Member Author

Trott commented May 20, 2016

Landed in b6a646d

@Trott Trott closed this May 20, 2016
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
Reduce unnecessarily verbose paragraph to a sentence.

PR-URL: #6801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
Reduce unnecessarily verbose paragraph to a sentence.

PR-URL: #6801
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@Trott Trott deleted the verbosity branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants