Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process: remove deprecated process.EventEmitter #6862

Closed
wants to merge 1 commit into from
Closed

process: remove deprecated process.EventEmitter #6862

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 18, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

process

Description of change

process.EventEmitter was deprecated for v6. This commit removes it for v7.

Refs: #5049

@cjihrig
process: remove deprecated process.EventEmitter
53c6050 
process.EventEmitter was deprecated for v6. This commit removes
it for v7.
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label May 18, 2016
@cjihrig cjihrig added process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version. labels May 18, 2016
@bnoordhuis
Copy link
Member

LGTM!

@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/2692/

LGTM if it’s green.

@jasnell
Copy link
Member

jasnell commented May 18, 2016

LGTM

@ChALkeR ChALkeR mentioned this pull request May 18, 2016
Closed
@Fishrock123
Copy link
Contributor

Aren't we supposed to leave it for an LTS cycle? -1?

@bnoordhuis
Copy link
Member

I think we can consider that condition fulfilled: it was deprecated almost five years ago.

@cjihrig
Copy link
Contributor Author

cjihrig commented May 18, 2016

Where is that policy exactly? It might be a matter of interpretation, as it wouldn't show up in LTS until Node v8.

cjihrig added a commit that referenced this pull request May 24, 2016
@cjihrig
process: remove deprecated process.EventEmitter
62b5442 
process.EventEmitter was deprecated for v6. This commit removes
it for v7.

Refs: #5049
PR-URL: #6862
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig
Copy link
Contributor Author

cjihrig commented May 24, 2016

Landed in 62b5442.

@cjihrig cjihrig closed this May 24, 2016
@cjihrig cjihrig deleted the rm-ee branch May 24, 2016 16:52
@mysticatea mysticatea mentioned this pull request Oct 26, 2016
Closed
@pimterry pimterry mentioned this pull request Feb 10, 2017
Open
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. process Issues and PRs related to the process subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjihrig @bnoordhuis @addaleax @jasnell @Fishrock123 @nodejs-github-bot