doc: reference list of language-specific globals #6900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,6 +5,10 @@ | |||
| These objects are available in all modules. Some of these objects aren't | |||
| actually in the global scope but in the module scope - this will be noted. | |||
|
|
|||
| The objects listed here are specific to Node.js. There is a number of | |||
There was a problem hiding this comment.
I think the second sentence should start with "There are a number...", but I'm not sure. Feel free to ignore.
|
LGTM |
addaleax
force-pushed
the
doc-language-globals
branch
from
d531f54
to
fc4ab82
Compare
|
Updated anyway, both sound okay to me but you’re the native speaker here. :) |
|
LGTM |
1 similar comment
|
LGTM |
|
Landed in 2193a2e |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
Fixes: nodejs#6894 PR-URL: nodejs#6900 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Fixes: #6894