Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify buffer class #6914

Closed
wants to merge 1 commit into from
Closed

doc: clarify buffer class #6914

wants to merge 1 commit into from

Conversation

stevemao
Copy link
Contributor

Fixes #6891

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 21, 2016
@claudiorodriguez
Copy link
Contributor

LGTM

@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label May 21, 2016
@jasnell
Copy link
Member

jasnell commented May 21, 2016

LGTM

2 similar comments
@ChALkeR
Copy link
Member

ChALkeR commented May 21, 2016

LGTM

@addaleax
Copy link
Member

LGTM

@addaleax
Copy link
Member

Landed in cc6a78e

@addaleax addaleax closed this May 24, 2016
addaleax pushed a commit that referenced this pull request May 24, 2016
@stevemao @addaleax
doc: clarify buffer class
cc6a78e 
Fixes: #6891
PR-URL: #6914
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
@stevemao @Fishrock123
doc: clarify buffer class
7a29c6f 
Fixes: nodejs#6891
PR-URL: nodejs#6914
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@stevemao @rvagg
doc: clarify buffer class
ee1865d 
Fixes: #6891
PR-URL: #6914
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jun 2, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jun 3, 2016
@stevemao
doc: clarify buffer class
0d054e2 
Fixes: #6891
PR-URL: #6914
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@stevemao
doc: clarify buffer class
c31eaad 
Fixes: #6891
PR-URL: #6914
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
@stevemao
doc: clarify buffer class
529533e 
Fixes: #6891
PR-URL: #6914
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@stevemao @claudiorodriguez @jasnell @ChALkeR @addaleax @mscdex @MylesBorins @nodejs-github-bot