Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: pretty-print SIMD types #6917

Merged
merged 1 commit into from
May 23, 2016
Merged

util: pretty-print SIMD types #6917

merged 1 commit into from
May 23, 2016

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented May 21, 2016 •
edited
Loading

Before:

Bool32x4 {}
Float32x4 {}
Int32x4 {}
// etc.

After:

Bool32x4 [ false, false, false, false ]
Float32x4 [ NaN, NaN, NaN, NaN ]
Int32x4 [ 0, 0, 0, 0 ]
// etc.

CI: https://ci.nodejs.org/job/node-test-pull-request/2724/

@bnoordhuis bnoordhuis added the util Issues and PRs related to the built-in util module. label May 21, 2016
@eljefedelrodeodeljefe
Copy link
Contributor

Cool. LGTM.

@jasnell
Copy link
Member

jasnell commented May 22, 2016

LGTM

@bnoordhuis
Copy link
Member Author

New run because of CI funkiness: https://ci.nodejs.org/job/node-test-pull-request/2738/

@bnoordhuis
util: pretty-print SIMD types
ee8e7cd 
Before:

    Bool32x4 {}
    Float32x4 {}
    Int32x4 {}
    // etc.

After:

    Bool32x4 [ false, false, false, false ]
    Float32x4 [ NaN, NaN, NaN, NaN ]
    Int32x4 [ 0, 0, 0, 0 ]
    // etc.

PR-URL: nodejs#6917
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
@bnoordhuis bnoordhuis closed this May 23, 2016
@bnoordhuis bnoordhuis deleted the pretty-print-simd branch May 23, 2016 10:21
@bnoordhuis
Copy link
Member Author

java.nio.file.DirectoryNotEmptyException on one of the Windows buildbots but everything else is green. Landed in ee8e7cd, thanks for the reviews.

@bnoordhuis bnoordhuis merged commit ee8e7cd into nodejs:master May 23, 2016
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
@bnoordhuis @Fishrock123
util: pretty-print SIMD types
3e4dd1a 
Before:

    Bool32x4 {}
    Float32x4 {}
    Int32x4 {}
    // etc.

After:

    Bool32x4 [ false, false, false, false ]
    Float32x4 [ NaN, NaN, NaN, NaN ]
    Int32x4 [ 0, 0, 0, 0 ]
    // etc.

PR-URL: #6917
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@bnoordhuis @rvagg
util: pretty-print SIMD types
d270706 
Before:

    Bool32x4 {}
    Float32x4 {}
    Int32x4 {}
    // etc.

After:

    Bool32x4 [ false, false, false, false ]
    Float32x4 [ NaN, NaN, NaN, NaN ]
    Int32x4 [ 0, 0, 0, 0 ]
    // etc.

PR-URL: #6917
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnoordhuis @eljefedelrodeodeljefe @jasnell