Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add firedfox to collaborators #6961

Closed

Conversation

firedfox
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

add firedfox to collaborators

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 25, 2016
@firedfox
Copy link
Contributor Author

@Trott
Copy link
Member

Trott commented May 25, 2016

LGTM

firedfox added a commit that referenced this pull request May 25, 2016
PR-URL: #6961
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented May 25, 2016

@firedfox: Don't forget to close this PR with "Landed in 54785f5" and sorry I forgot to mention it during onboarding!

@firedfox
Copy link
Contributor Author

Landed in 54785f5

@firedfox firedfox closed this May 25, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
PR-URL: nodejs#6961
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #6961
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
PR-URL: #6961
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6961
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6961
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6961
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6961
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants