Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add regression test for Proxy as vm context #6967

Merged
merged 1 commit into from
May 26, 2016
Merged

test: add regression test for Proxy as vm context #6967

merged 1 commit into from
May 26, 2016

Conversation

targos
Copy link
Member

@targos targos commented May 25, 2016

Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

vm

Description of change

This is a regression test for the issue #6158 that was fixed by #6928.

@targos targos added vm Issues and PRs related to the vm subsystem. test Issues and PRs related to the tests. labels May 25, 2016
@thefourtheye
Copy link
Contributor

LGTM

@thefourtheye
Copy link
Contributor

CI Run: https://ci.nodejs.org/job/node-test-pull-request/2780/

@cjihrig
Copy link
Contributor

cjihrig commented May 25, 2016

LGTM. The provided CI URL is a 404.

@thefourtheye
Copy link
Contributor

Oops. Sorry. I have no idea what happened there. New CI Run: https://ci.nodejs.org/job/node-test-pull-request/2781/

@jasnell
Copy link
Member

jasnell commented May 25, 2016

LGTM

1 similar comment
@addaleax
Copy link
Member

LGTM

@targos
test: add regression test for Proxy as vm context
f9ea52e 
A Proxy context should not hide built-in global objects.
Ref: nodejs#6158

PR-URL: nodejs#6967
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos merged commit f9ea52e into nodejs:master May 26, 2016
@targos targos deleted the regress-6158 branch May 26, 2016 07:51
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
@targos @Fishrock123
test: add regression test for Proxy as vm context
4f1c108 
A Proxy context should not hide built-in global objects.
Ref: nodejs#6158

PR-URL: nodejs#6967
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@targos @rvagg
test: add regression test for Proxy as vm context
6f3f5af 
A Proxy context should not hide built-in global objects.
Ref: #6158

PR-URL: #6967
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
@MylesBorins
Copy link
Contributor

@targos lts?

@targos
Copy link
Member Author

targos commented Jul 12, 2016

No. v4 doesn't have proxies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @thefourtheye @cjihrig @jasnell @addaleax @MylesBorins