Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add added: information for net #7038

Merged
merged 40 commits into from
Jun 3, 2016
Merged

doc: add added: information for net #7038

merged 40 commits into from
Jun 3, 2016

Conversation

italoacasas
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Add added: information for net

Ref: #6578

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 28, 2016
@mscdex mscdex added the net Issues and PRs related to the net subsystem. label May 28, 2016
@sam-github sam-github mentioned this pull request May 28, 2016
Closed
36 tasks
addaleax
addaleax reviewed May 29, 2016
View reviewed changes
doc/api/net.md
@@ -7,35 +7,53 @@ functions for creating both servers and clients (called streams). You can includ
this module with `require('net');`.

## Class: net.Server
<!-- YAML
added: v0.7.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? The docs change in which it was introduced seems to be in 499c615

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap you are right. thanks

@addaleax
Copy link
Member

addaleax commented Jun 1, 2016

Generally looking good, with a few comments… really appreciate the hard work behind this!

@italoacasas
Copy link
Contributor Author

italoacasas commented Jun 1, 2016 •
edited
Loading

tomorrow I'm going to check server.listen because is a little bit more harder to find, thanks for the help @addaleax

@addaleax
Copy link
Member

addaleax commented Jun 2, 2016

LGTM

@addaleax addaleax merged commit 8bccc9e into nodejs:master Jun 3, 2016
@addaleax
Copy link
Member

addaleax commented Jun 3, 2016

Merged, thanks for the effort you put into this!

evanlucas pushed a commit that referenced this pull request Jun 15, 2016
@italoacasas @evanlucas
doc: add added information for net
026bf17 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@italoacasas @addaleax
doc: add added information for net
1046532 
Ref: nodejs#6578
PR-URL: nodejs#7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@italoacasas
doc: add added information for net
664dc3b 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@italoacasas
doc: add added information for net
db153ea 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@italoacasas
doc: add added information for net
99723b2 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@italoacasas
doc: add added information for net
78d361b 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@italoacasas @addaleax @mscdex @MylesBorins @nodejs-github-bot