test: fix tests for non-crypto builds #7056
Conversation
|
LGTM if CI doesn't find any surprises |
|
Nice, LGTM. |
|
LGTM |
| common.skip('missing crypto'); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Perhaps the crypto AsyncWrap test can merely be isolated instead of aborting the entire test?
There was a problem hiding this comment.
Hm, this test is basically laid out to use all providers, so I guess that would really require its own test file… I’m not sure that’s worth the trouble.
|
Minor aside: I've been wondering about the possibility of refactoring |
|
LGTM |
|
@jasnell regarding preloading common, #2836 (comment) |
Fix running the tests when node was compiled without crypto support. Some of these are cleanup after 52bae22, where common was used before it was required.
addaleax
force-pushed
the
fix-tests-for-disabled-features
branch
from
37f4f9b
to
df2777b
Compare
|
Addressed @jasnell’s nit, one more CI: |
|
Landed in 15cd45c |
Fix running the tests when node was compiled without crypto support. Some of these are cleanup after 52bae22, where common was used before it was required. PR-URL: #7056 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
This is not landing cleanly on v6.x, so going to hold off for now |
|
@addaleax assuming dont land on v4.x? |
|
Seems okay not to backport, yes. |
Checklist
Affected core subsystem(s)
test
Description of change
Fix running the tests when node was compiled without crypto support. Some of these were introduced in 52bae22, where
commonwas used before it was required.Regular CI: https://ci.nodejs.org/job/node-test-commit/3575/
/cc @nodejs/testing