doc: edit pull request template #7058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
|
LGTM |
| @@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md | |||
| --> | |||
|
|
|||
| ##### Checklist | |||
| <!-- remove lines that do not apply to you --> | |||
| <!-- Remove items that do not apply, For completed items, change [ ] to [x]. --> | |||
There was a problem hiding this comment.
I would change the comma to a period after "apply".
There was a problem hiding this comment.
Maybe also remove the period at the end of this?
|
LGTM with a nit |
Move checklist instructions closer to the checklist. Trim unnecessary words.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2016
Move checklist instructions closer to the checklist. Trim unnecessary words. PR-URL: nodejs#7058 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
|
Landed in e350deb |
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
Move checklist instructions closer to the checklist. Trim unnecessary words. PR-URL: #7058 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Move checklist instructions closer to the checklist. Trim unnecessary
words.