tools: fix license builder to work with icu-small #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if @srl295 is happy with it |
|
LGTM |
|
this is only worth keeping in this format for the purpose of backporting to 4.x and 0.12 right? |
|
@rvagg this fix is required to get the license builder to work on master. The folder-name used by the checked in ICU is different from what the license builder is currently grepping for |
|
yeah, I'm thinking out loud sorry, in master we could actually get rid of all the conditions as we already have small-ucy in tree, but if we want to keep the tool consistent across branches then we'll have to go with that |
|
Ahh that makes sense. In theory we could remove all the cases from master and simply leave the license builder in v4 < exactly the way it is. More than happy to update that |
|
ICU has a new owner so there's some change there. |
Currently the license builder is expecting the ICU package to be found at `deps/icu`. ICU is now included by default and found at `deps/icu-small`. This commit adds logic to find the license at the new location. This could likely be done in a more elegant way, but it works! PR-URL: nodejs#7119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
MylesBorins
force-pushed
the
fix-license-builder
branch
from
410552b
to
5fd6d75
Compare
evanlucas
pushed a commit
that referenced
this pull request
Jun 16, 2016
Currently the license builder is expecting the ICU package to be found at `deps/icu`. ICU is now included by default and found at `deps/icu-small`. This commit adds logic to find the license at the new location. This could likely be done in a more elegant way, but it works! PR-URL: #7119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
Currently the license builder is expecting the ICU package to be found at `deps/icu`. ICU is now included by default and found at `deps/icu-small`. This commit adds logic to find the license at the new location. This could likely be done in a more elegant way, but it works! PR-URL: #7119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Currently the license builder is expecting the ICU package to be found at `deps/icu`. ICU is now included by default and found at `deps/icu-small`. This commit adds logic to find the license at the new location. This could likely be done in a more elegant way, but it works! PR-URL: #7119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Currently the license builder is expecting the ICU package to be found at `deps/icu`. ICU is now included by default and found at `deps/icu-small`. This commit adds logic to find the license at the new location. This could likely be done in a more elegant way, but it works! PR-URL: #7119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Currently the license builder is expecting the ICU package to be found at `deps/icu`. ICU is now included by default and found at `deps/icu-small`. This commit adds logic to find the license at the new location. This could likely be done in a more elegant way, but it works! PR-URL: #7119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Currently the license builder is expecting the ICU package to be found at `deps/icu`. ICU is now included by default and found at `deps/icu-small`. This commit adds logic to find the license at the new location. This could likely be done in a more elegant way, but it works! PR-URL: #7119 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
|
OK- so as of http://bugs.icu-project.org/trac/ticket/12452 the BOM and trailing spaces and junk are fixed in ICU trunk. so for ICU 58 #7844 … would be sufficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
Currently the license builder is expecting the ICU package to be
found at
deps/icu. ICU is now included by default and found atdeps/icu-small. This commit adds logic to find the license at the newlocation.
This could likely be done in a more elegant way, but it works!
/cc @srl295 @jasnell