benchmark: util._extend vs object.assign
#7255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To copy the values of all enumerable own properties from- a source object to a target object, node still use- `util._extend`, though newer standard `Object.assign` is available. This is because `util._extend` is found to be faster than `Object.assign`. This benchmark test is to keep track of how performance compare.
nodejs-github-bot
added
the
benchmark
2 tasks
mscdex
added
util
|
|
||
| const bench = common.createBenchmark(main, { | ||
| type: ['util._extend', 'Object.assign', | ||
| 'util._extend', 'Object.assign'], |
| if (conf.type === 'extend') { | ||
| fn = util._extend; | ||
| v8command = '%OptimizeFunctionOnNextCall(util._extend)'; | ||
| } else if (conf.type === 'assign') { |
There was a problem hiding this comment.
FYI: https://github.com/nodejs/node/blob/master/benchmark/common.js#L255
the benchmark/common.js now has a method for handling the details of v8 optimization for you. e.g.
function myMethod(a,b) {
/** ... **/
}
common.v8ForceOptimization(myMethod, 'a', 'b');
myMethod('a', 'b');
|
Couple of minor nits but LGTM if @mscdex is happy with it. |
| v8command = '%OptimizeFunctionOnNextCall(util._extend)'; | ||
| } else if (conf.type === 'assign') { | ||
| fn = Object.assign; | ||
| //Object.assign is built-in, cannot be optimized |
|
One minor style nit, but otherwise LGTM |
fixed spacing nit.
|
Fixed the minor style. |
jasnell
pushed a commit
that referenced
this pull request
Jun 27, 2016
To copy the values of all enumerable own properties from- a source object to a target object, node still use- `util._extend`, though newer standard `Object.assign` is available. This is because `util._extend` is found to be faster than `Object.assign`. This benchmark test is to keep track of how performance compare. PR-URL: #7255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
Landed in 6abb06f |
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
To copy the values of all enumerable own properties from- a source object to a target object, node still use- `util._extend`, though newer standard `Object.assign` is available. This is because `util._extend` is found to be faster than `Object.assign`. This benchmark test is to keep track of how performance compare. PR-URL: #7255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
3 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
benchmark
Description of change
To copy the values of all enumerable properties from-
a source object to a target object, node still use-
util._extend, though newer standardObject.assignis available. This is because
util._extendis found tobe faster than
Object.assign. This benchmark test isto keep track of how performance compare.