inspector: Fix the inspector connection cleanup #7268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
2 tasks
|
Relaunched CI: https://ci.nodejs.org/job/node-test-commit/3765/. Looks green. PTAL @nodejs/diagnostics. |
| @@ -401,14 +401,13 @@ void AgentImpl::ThreadCbIO(void* agent) { | |||
| // static | |||
| void AgentImpl::OnSocketConnectionIO(uv_stream_t* server, int status) { | |||
| if (status == 0) { | |||
| inspector_socket_t* socket = | |||
| static_cast<inspector_socket_t*>(malloc(sizeof(*socket))); | |||
| inspector_socket_t* socket = new inspector_socket_t(); | |||
| ASSERT_NE(nullptr, socket); | |||
There was a problem hiding this comment.
The ASSERT_NE is useless now (and should have been a CHECK_EQ in hindsight.)
In some cases close callback was called twice, while in some cases the memory was still not released at all.
|
LGTM |
ofrobots
pushed a commit
that referenced
this pull request
Jun 17, 2016
In some cases close callback was called twice, while in some cases the memory was still not released at all. PR-URL: #7268 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
|
Landed as 9dfc8b9. |
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
In some cases close callback was called twice, while in some cases the memory was still not released at all. PR-URL: #7268 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
This change only touches inspector connection
Description of change
In some cases close callback was called twice while other codepaths ended up
not releasing the memory at all.
CC: @ofrobots