Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add CTC meeting minutes 2016-06-15 #7320

Closed
wants to merge 1 commit into from

Conversation

joshgav
Copy link
Contributor

@joshgav joshgav commented Jun 16, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

add CTC meeting minutes 2016-06-15
closes #7307

/cc @nodejs/ctc for review/corrections

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 16, 2016
@joshgav joshgav force-pushed the june-15-ctc-meeting branch from 99d2c36 to 150aff2 Compare June 16, 2016 15:47
@trott: semver-major change, needs approval from CTC.
Real fix will be @jasnell’s HTTP compliance work.

In browsers `file:/home/joshgav/myfile.txt` is auto-corrected to `file:///home/joshgav/myfile.txt` (i.e. slashes are prepended to the path and hostname is an empty string). This change institutes the same in Node.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total nit: Node -> Node.js

@Trott
Copy link
Member

Trott commented Jun 16, 2016

LGTM at least for the parts of the meeting that I was there for. (I had to leave in the middle of the modules discussion.)

@Trott
Copy link
Member

Trott commented Jun 16, 2016

(Also, thanks for taking notes!!!!!)

@joshgav joshgav force-pushed the june-15-ctc-meeting branch from 150aff2 to d865e6d Compare June 16, 2016 19:47
@joshgav
Copy link
Contributor Author

joshgav commented Jun 23, 2016

@Trott @rvagg can we merge this? do you want me to rebase first? Thanks!

@Trott
Copy link
Member

Trott commented Jun 23, 2016

Fine with me, but I think it would be nice to have at least one more LGTM from a @nodejs/ctc member. I wasn't there for the whole meeting.

@rvagg
Copy link
Member

rvagg commented Jun 27, 2016

lgtm, landed @ a28d373

rvagg pushed a commit that referenced this pull request Jun 27, 2016
PR-URL: #7320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
PR-URL: #7320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
PR-URL: #7320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
PR-URL: #7320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #7320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #7320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #7320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7320
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@jasnell jasnell closed this Aug 1, 2016
@joshgav joshgav deleted the june-15-ctc-meeting branch August 3, 2016 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node.js Foundation Core Technical Committee (CTC) Meeting 2016-06-15
6 participants