-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add CTC meeting minutes 2016-06-15 #7320
Conversation
99d2c36
to
150aff2
Compare
@trott: semver-major change, needs approval from CTC. | ||
Real fix will be @jasnell’s HTTP compliance work. | ||
|
||
In browsers `file:/home/joshgav/myfile.txt` is auto-corrected to `file:///home/joshgav/myfile.txt` (i.e. slashes are prepended to the path and hostname is an empty string). This change institutes the same in Node. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Total nit: Node
-> Node.js
LGTM at least for the parts of the meeting that I was there for. (I had to leave in the middle of the modules discussion.) |
(Also, thanks for taking notes!!!!!) |
150aff2
to
d865e6d
Compare
Fine with me, but I think it would be nice to have at least one more LGTM from a @nodejs/ctc member. I wasn't there for the whole meeting. |
lgtm, landed @ a28d373 |
PR-URL: #7320 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #7320 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #7320 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #7320 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #7320 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #7320 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #7320 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #7320 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #7320 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Checklist
Affected core subsystem(s)
doc
Description of change
add CTC meeting minutes 2016-06-15
closes #7307
/cc @nodejs/ctc for review/corrections