deps: backport 7dfb5beeec from V8 upstream #7348
Conversation
nodejs-github-bot
added
the
v8 engine
|
ci: https://ci.nodejs.org/job/node-test-pull-request/3044/ /cc @ofrobots @nodejs/v8 |
|
Any reason to rush it and not wait until it will be merged into V8 5.2? |
|
Based on the reddit thread it seemed like people were running into this problem in production. We can likely wait on it, but I wasn't sure how long it would take to prove out that the V8 5.2 update is non ABI breaking |
|
@thealphanerd 👍 then. |
|
@thealphanerd Can you request a back-port to 5.0 and 5.1 upstream? Then we can just upgrade wholesale. |
|
Also, it looks like v6 is affected but v4 and v5 are not. |
|
@bnoordhuis more than happy to. What is the process for doing so? |
|
I have opened a backport request in the chromium tracker https://codereview.chromium.org/2087803004/ @ofrobots seems to imply that we should likely float for V8 5 until nodejs/Release#111 has been sorted |
|
This got cherry-picked onto in V8 5.1 earlier today. As far as V8 5.0 is concerned, that branch is no longer getting tested, and there is no official process to merge changes into it, until nodejs/Release#111 gets to closure. /cc @natorion Until then I think we should float this patch. @thealphanerd instead if the reddit link, could you link to the upstream bug for this issue: https://bugs.chromium.org/p/chromium/issues/detail?id=604033. Otherwise this LGTM as long as V8 tests pass. |
|
LGTM but I second Ali's comment about the reddit link. |
|
Link updated. In future I'll double check the chromium tracker first 😄 V8 tests passed, just waiting on a fresh run of the CI |
|
LGTM. |
This commit backports a fix to a JIT bug in V8. After 100 or so comparisons `typeof null ==="undefined"` is returning `true` instead of `false`. Original commit message: Fix 'typeof null' canonicalization in crankshaft BUG= Review URL: https://codereview.chromium.org/1912553002 Cr-Commit-Position: refs/heads/master@{nodejs#35699} Ref: https://bugs.chromium.org/p/chromium/issues/detail?id=604033
|
thanks @targos I was doing s/v/V and accidentally s/v/B'd ¯_(ツ)_/¯ |
MylesBorins
changed the title
|
landed in a84b0f2 |
This commit backports a fix to a JIT bug in V8. After 100 or so comparisons `typeof null ==="undefined"` is returning `true` instead of `false`. Original commit message: Fix 'typeof null' canonicalization in crankshaft BUG= Review URL: https://codereview.chromium.org/1912553002 Cr-Commit-Position: refs/heads/master@{#35699} Ref: https://bugs.chromium.org/p/chromium/issues/detail?id=604033 PR-URL: #7348 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
This commit backports a fix to a JIT bug in V8. After 100 or so comparisons `typeof null ==="undefined"` is returning `true` instead of `false`. Original commit message: Fix 'typeof null' canonicalization in crankshaft BUG= Review URL: https://codereview.chromium.org/1912553002 Cr-Commit-Position: refs/heads/master@{#35699} Ref: https://bugs.chromium.org/p/chromium/issues/detail?id=604033 PR-URL: #7348 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
|
I've gone ahead and landed this on |
This commit backports a fix to a JIT bug in V8. After 100 or so comparisons `typeof null ==="undefined"` is returning `true` instead of `false`. Original commit message: Fix 'typeof null' canonicalization in crankshaft BUG= Review URL: https://codereview.chromium.org/1912553002 Cr-Commit-Position: refs/heads/master@{#35699} Ref: https://bugs.chromium.org/p/chromium/issues/detail?id=604033 PR-URL: nodejs/node#7348 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
deps
Description of change
This commit backports a fix to a JIT bug in V8.
After 100 or so comparisons
typeof null ==="undefined"is returningtrueinstead offalse.Original commit message: