test: fix flaky test-fs-watch-encoding on OS X #7356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
fs
| // around issues on OS X and SmartOS. | ||
| // | ||
| // On OS X, watch events are subject to peculiar timing oddities such that an | ||
| // event might fire our of order. The synchronous refreshing of the tmp |
|
LGTM with typo. |
|
LGTM |
| const common = require('../common'); | ||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const assert = require('assert'); | ||
|
|
||
| if (common.isFreeBSD) { | ||
| common.skip('Test currently not working on FreeBSD'); |
There was a problem hiding this comment.
You can remove this. The test now passes in FreeBSD because of the interval
|
Rebased, nits fixed, force pushed, new CI: https://ci.nodejs.org/job/node-test-pull-request/3051/ |
|
CI again: https://ci.nodejs.org/job/node-test-pull-request/3052/ Hooray, yellow, not red, I'll take it. |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 24, 2016
PR-URL: nodejs#7356 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
Landed in 5267f29 |
Fishrock123
pushed a commit
that referenced
this pull request
Jun 27, 2016
PR-URL: #7356 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
PR-URL: #7356 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
|
@Trott lts? |
|
@thealphanerd No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test fs
Description of change
Depends on #7327. More info after that lands...
Copy of shell script used to stress test locally for the problem:
Script (named
stress.shin the project root) instantiated with:bash stress.sh test-fs-watch-encoding 4Without change in this PR, it fails after a handful of runs, usually less than 10 and never more than 100. With this change, it does not seem to fail at all.