Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: use arrow functions for lexical this #7415

Closed
wants to merge 3 commits into from
Closed

debug: use arrow functions for lexical this #7415

wants to merge 3 commits into from

Conversation

originalfoo
Copy link
Contributor

@originalfoo originalfoo commented Jun 25, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

debug

( specifically: lib/_debug_agent.js )

Description of change

Use arrow functions to replace 3x var self = this; ... function() { self.whatever() } pattern.

See #7414 for more details.

@mscdex
Copy link
Contributor

mscdex commented Jun 25, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3076/

@cjihrig
Copy link
Contributor

cjihrig commented Jun 27, 2016

LGTM

2 similar comments
@jasnell
Copy link
Member

jasnell commented Jun 27, 2016

LGTM

@mscdex
Copy link
Contributor

mscdex commented Jun 27, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Aug 18, 2016

New CI since it appears this fell through the cracks: https://ci.nodejs.org/job/node-test-pull-request/3742/

jasnell pushed a commit that referenced this pull request Aug 18, 2016
@originalfoo @jasnell
debugger: use arrow function for lexical this
a9387db 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell
Copy link
Member

jasnell commented Aug 18, 2016

Landed in a9387db!

@jasnell jasnell closed this Aug 18, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@originalfoo @evanlucas
debugger: use arrow function for lexical this
c406ad8 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@originalfoo
debugger: use arrow function for lexical this
9de701a 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@originalfoo
debugger: use arrow function for lexical this
0d4bb79 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@originalfoo
debugger: use arrow function for lexical this
74f76f6 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@originalfoo @rvagg
debugger: use arrow function for lexical this
6dd3390 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@originalfoo @MylesBorins
debugger: use arrow function for lexical this
2b93333 
Refs: #7414
PR-URL: #7415
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@originalfoo @mscdex @cjihrig @jasnell @MylesBorins @nodejs-github-bot