Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add v8 requirement to test-v8* in Makefile #7482

Closed
wants to merge 2 commits into from
Closed

build: add v8 requirement to test-v8* in Makefile #7482

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 29, 2016

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

The test targets expect that V8 is built in deps/v8/out

Ref: #7477

@targos
build: add v8 requirement to test-v8* in Makefile
3ef9961 
The test targets expect that V8 is built in deps/v8/out

Ref: nodejs#7477
@targos targos added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels Jun 29, 2016
@targos targos mentioned this pull request Jun 29, 2016
Closed
@MylesBorins
Copy link
Contributor

I was just about to submit this, testing locally.

LGTM

@targos targos force-pushed the fix-makefile-v8 branch from 2081e99 to fd57181 Compare June 30, 2016 06:07
@targos
build: use BUILDTYPE when building V8 in Makefile
75182eb 
Without this it would always compile Release and Debug builds.
@targos targos force-pushed the fix-makefile-v8 branch from fd57181 to 75182eb Compare June 30, 2016 06:09
@targos
Copy link
Member Author

targos commented Jun 30, 2016

I added a second commit to use the BUILDTYPE variable in make v8. PTAL

cc @exinfinitum who can maybe explain why it was done differently.

@jasnell
Copy link
Member

jasnell commented Jun 30, 2016

LGTM

@targos
Copy link
Member Author

targos commented Jul 8, 2016

@thealphanerd LGTY with the second commit ?

@MylesBorins
Copy link
Contributor

@targos what is the build type variable used for?

@targos
Copy link
Member Author

targos commented Jul 8, 2016

If we don't specify the build type, both Release and Debug builds will be compiled (you can see it here).
The value of this variable is Release by default so passing it makes us win some time while still allowing to build a Debug build if it's needed.

@MylesBorins
Copy link
Contributor

LGTM

targos added a commit to targos/node that referenced this pull request Jul 10, 2016
@targos
build: add v8 requirement to test-v8* in Makefile
69ef9b1 
The test targets expect that V8 is built in deps/v8/out

Ref: nodejs#7477
PR-URL: nodejs#7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit to targos/node that referenced this pull request Jul 10, 2016
@targos
build: use BUILDTYPE when building V8 in Makefile
22492db 
Without this it would always compile Release and Debug builds.

Ref: nodejs#7477
PR-URL: nodejs#7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member Author

targos commented Jul 10, 2016

Landed in 69ef9b1 and 22492db

@targos targos closed this Jul 10, 2016
@targos targos deleted the fix-makefile-v8 branch July 10, 2016 15:23
@MylesBorins
Copy link
Contributor

@targos this is not landing cleanly on v4.x would you be willing to backport

targos added a commit that referenced this pull request Jul 12, 2016
@targos
build: add v8 requirement to test-v8* in Makefile
b68e685 
The test targets expect that V8 is built in deps/v8/out

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Jul 12, 2016
@targos
build: use BUILDTYPE when building V8 in Makefile
110ce55 
Without this it would always compile Release and Debug builds.

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member Author

targos commented Jul 12, 2016 •
edited
Loading

Landed in v4.x-staging as b68e685 and 110ce55

MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@targos
build: add v8 requirement to test-v8* in Makefile
dfba60e 
The test targets expect that V8 is built in deps/v8/out

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@targos
build: use BUILDTYPE when building V8 in Makefile
d7f7795 
Without this it would always compile Release and Debug builds.

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@targos
build: add v8 requirement to test-v8* in Makefile
de5d718 
The test targets expect that V8 is built in deps/v8/out

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@targos
build: use BUILDTYPE when building V8 in Makefile
5841332 
Without this it would always compile Release and Debug builds.

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
evanlucas pushed a commit that referenced this pull request Jul 13, 2016
@targos @evanlucas
build: add v8 requirement to test-v8* in Makefile
94a486a 
The test targets expect that V8 is built in deps/v8/out

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jul 13, 2016
@targos @evanlucas
build: use BUILDTYPE when building V8 in Makefile
4480b14 
Without this it would always compile Release and Debug builds.

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@targos
build: add v8 requirement to test-v8* in Makefile
6fce484 
The test targets expect that V8 is built in deps/v8/out

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@targos
build: use BUILDTYPE when building V8 in Makefile
728eab1 
Without this it would always compile Release and Debug builds.

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@targos
build: add v8 requirement to test-v8* in Makefile
79bd39c 
The test targets expect that V8 is built in deps/v8/out

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@targos
build: use BUILDTYPE when building V8 in Makefile
5290c9d 
Without this it would always compile Release and Debug builds.

Ref: #7477
PR-URL: #7482
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Jul 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@targos @MylesBorins @jasnell