Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix build failure for clang 3.2; consolidate byte swapping code; fix buffer writes for unaligned ucs2 strings #7645

Closed
wants to merge 2 commits into from
Closed

src: fix build failure for clang 3.2; consolidate byte swapping code; fix buffer writes for unaligned ucs2 strings #7645

wants to merge 2 commits into from

Commits on Sep 30, 2016

  1. src: fix build for older clang 

    Removes use of builtins that are unavailable for older clang. Per
benchmarks, only uses builtins on Windows, where speedup is
significant.

Fixes: nodejs#7618
    @zbjornson
    zbjornson committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    62ba6c8 View commit details
    Browse the repository at this point in the history

  2. test: add test for unaligned ucs2 buffer write 

    Between nodejs#3410 and nodejs#7645, bytes were swapped twice on bigendian
platforms if buffer was not two-byte aligned. See comment in nodejs#7645.
    @zbjornson
    zbjornson committed Sep 30, 2016
    Configuration menu
    Copy the full SHA
    2b69933 View commit details
    Browse the repository at this point in the history