-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: ensure stream preprocessing order #7741
Closed
vsemozhetbyt
wants to merge
11
commits into
nodejs:master
from
vsemozhetbyt:test-fixtures-stream-preprocess
Closed
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
df751d9
test: ensure stream preprocessing order
vsemozhetbyt 50fd2c8
Delete stream-preprocess.js
vsemozhetbyt 06f89b8
Delete file-to-read-without-bom.txt
vsemozhetbyt d74e6df
Delete file-to-read-with-bom.txt
vsemozhetbyt 62379f3
Add .txt files to fixtures
vsemozhetbyt 099a111
Add test-stream-preprocess.js to parallel
vsemozhetbyt a05ea83
Fix test-stream-preprocess.js style issues
vsemozhetbyt 473da05
Fix another test-stream-preprocess.js style issue
vsemozhetbyt 376ea47
Use common.fixturesDir, add some more assertions
vsemozhetbyt f41dca2
Remove redundant assertions
vsemozhetbyt 6d7e25f
Fix comments style and variable name
vsemozhetbyt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
abc | ||
def | ||
ghi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
abc | ||
def | ||
ghi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
const assert = require('assert'); | ||
|
||
const fs = require('fs'); | ||
const path = require('path'); | ||
const rl = require('readline'); | ||
|
||
const BOM = '\uFEFF'; | ||
|
||
// get the data by a non-stream way to compare with the streamed data | ||
const modelData = fs.readFileSync( | ||
path.join(common.fixturesDir, 'file-to-read-without-bom.txt'), 'utf8' | ||
); | ||
const modelDataFirstCharacter = modelData[0]; | ||
|
||
// detect the number of forthcoming 'line' events for mustCall() 'expected' arg | ||
const linesNumber = modelData.match(/\n/g).length; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Maybe |
||
|
||
// ensure both without-bom and with-bom test files are textwise equal | ||
assert.strictEqual( | ||
fs.readFileSync( | ||
path.join(common.fixturesDir, 'file-to-read-with-bom.txt'), 'utf8' | ||
), | ||
`${BOM}${modelData}` | ||
); | ||
|
||
// an unjustified BOM stripping with a non-BOM character unshifted to a stream | ||
const inputWithoutBOM = fs.createReadStream( | ||
path.join(common.fixturesDir, 'file-to-read-without-bom.txt'), 'utf8' | ||
); | ||
|
||
inputWithoutBOM.once('readable', common.mustCall(() => { | ||
const maybeBOM = inputWithoutBOM.read(1); | ||
assert.strictEqual(maybeBOM, modelDataFirstCharacter); | ||
assert.notStrictEqual(maybeBOM, BOM); | ||
|
||
inputWithoutBOM.unshift(maybeBOM); | ||
|
||
let streamedData = ''; | ||
rl.createInterface({ | ||
input: inputWithoutBOM, | ||
}).on('line', common.mustCall((line) => { | ||
streamedData += `${line}\n`; | ||
}, linesNumber)).on('close', common.mustCall(() => { | ||
assert.strictEqual(streamedData, modelData); | ||
})); | ||
})); | ||
|
||
// a justified BOM stripping | ||
const inputWithBOM = fs.createReadStream( | ||
path.join(common.fixturesDir, 'file-to-read-with-bom.txt'), 'utf8' | ||
); | ||
|
||
inputWithBOM.once('readable', common.mustCall(() => { | ||
const maybeBOM = inputWithBOM.read(1); | ||
assert.strictEqual(maybeBOM, BOM); | ||
|
||
let streamedData = ''; | ||
rl.createInterface({ | ||
input: inputWithBOM, | ||
}).on('line', common.mustCall((line) => { | ||
streamedData += `${line}\n`; | ||
}, linesNumber)).on('close', common.mustCall(() => { | ||
assert.strictEqual(streamedData, modelData); | ||
})); | ||
})); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Comments should be capitalized and punctuated; also, maybe
using
is better thanby
?