Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #7742: src: --inspect notify contextDestroyed #7756

Closed
wants to merge 1 commit into from
Closed

Fixes #7742: src: --inspect notify contextDestroyed #7756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,9 @@ bool V8Inspector::canExecuteScripts()
return true;
}

void V8Inspector::notifyContextDestroyed()
{
m_debugger->contextDestroyed(m_context);
}

} // namespace blink
1 change: 1 addition & 0 deletions deps/v8_inspector/third_party/v8_inspector/platform/v8_inspector/public/V8Inspector.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class V8Inspector : public V8DebuggerClient, V8InspectorSessionClient {
void connectFrontend(protocol::FrontendChannel*);
void disconnectFrontend();
void dispatchMessageFromFrontend(const String16& message);
void notifyContextDestroyed();

private:
bool callingContextCanAccessContext(v8::Local<v8::Context> calling, v8::Local<v8::Context> target) override;
Expand Down
1 change: 1 addition & 0 deletions src/inspector_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,7 @@ bool AgentImpl::IsStarted() {
void AgentImpl::WaitForDisconnect() {
shutting_down_ = true;
fprintf(stderr, "Waiting for the debugger to disconnect...\n");
inspector_->notifyContextDestroyed();
inspector_->runMessageLoopOnPause(0);
}

Expand Down