Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add npm link to Readme, general cleanup #7769

Closed
wants to merge 4 commits into from
Closed

doc: add npm link to Readme, general cleanup #7769

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38e139b
doc: add npm link, formatting
oscarmorrison Jul 16, 2016
4961525
doc: formatting, based on feedback.
oscarmorrison Jul 16, 2016
88cc765
doc: updated nam link to npmjs.com
oscarmorrison Jul 17, 2016
0b074c2
doc: update nodejs.org url, remove en
oscarmorrison Jul 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ Node.js

Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine. Node.js
uses an event-driven, non-blocking I/O model that makes it lightweight and
efficient. The Node.js package ecosystem, npm, is the largest ecosystem of open
source libraries in the world.
efficient. The Node.js package ecosystem [npm](https://github.com/npm/npm),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comma before npm should not be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the link should rather go to https://www.npmjs.com/?

is the largest ecosystem of open source libraries in the world.

The Node.js project is supported by the
[Node.js Foundation](https://nodejs.org/en/foundation/). Contributions,
Expand All @@ -19,8 +19,8 @@ If you need help using or installing Node.js, please use the

## Resources for Newcomers

* [Website](https://nodejs.org/en/)
* [Contributing to the project](./CONTRIBUTING.md)
* Website: [nodejs.org](https://nodejs.org/en/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this wasn't part of this PR, but does anyone know why we are sending everyone to /en?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: #6681, /cc @Fishrock123.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, it was a copy-paste of what the default is.

This should be fixed.

* Contributing: [CONTRIBUTING.md](./CONTRIBUTING.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we making either of these changes?

I mean, especially this one? ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fishrock123 to be consistent with the rest of the text in that block.

Copy link
Contributor

@Fishrock123 Fishrock123 Jul 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, IRC is kinda special though because you could use the link but usually you'd just copy that into your client. I'm ok for the website, but not the Contributing link.

* IRC (general questions): [#node.js on chat.freenode.net](https://webchat.freenode.net?channels=node.js&uio=d4)
* IRC (node core development): [#node-dev on chat.freenode.net](https://webchat.freenode.net?channels=node-dev&uio=d4)

Expand Down