Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting misspelling #7797

Closed
wants to merge 1 commit into from
Closed

Correcting misspelling #7797

wants to merge 1 commit into from

Conversation

vitaly-t
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Changing stringp to string.

@vitaly-t
Correcting misspelling
dbeec79 
Changing `stringp` to `string`.
@nodejs-github-bot nodejs-github-bot added tls Issues and PRs related to the tls subsystem. doc Issues and PRs related to the documentations. labels Jul 19, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Jul 19, 2016

LGTM

3 similar comments
@silverwind
Copy link
Contributor

LGTM

@JungMinu
Copy link
Member

LGTM

@thefourtheye
Copy link
Contributor

LGTM

@silverwind
Copy link
Contributor

Thanks! Landed in 74f0943.

@silverwind silverwind closed this Jul 20, 2016
silverwind pushed a commit that referenced this pull request Jul 20, 2016
@vitaly-t @silverwind
doc: correcting misspelling
74f0943 
Changing `stringp` to `string`.

PR-URL: #7797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@silverwind
Copy link
Contributor

The issue was introduced in 1b6a468, which doesn't seem to have landed on LTS yet.

evanlucas pushed a commit that referenced this pull request Jul 21, 2016
@vitaly-t @evanlucas
doc: correcting misspelling
4839ef3 
Changing `stringp` to `string`.

PR-URL: #7797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@evanlucas evanlucas mentioned this pull request Jul 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vitaly-t @cjihrig @silverwind @JungMinu @thefourtheye @MylesBorins @nodejs-github-bot