Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Update V8 to 5.2 #7824

Closed
wants to merge 8 commits into from
Closed

[WIP] Update V8 to 5.2 #7824

wants to merge 8 commits into from

Commits on Jul 26, 2016

  1. deps: update V8 5.2.361.46 

    deps: edit v8 gitignore to allow trace event copy

deps: update v8 trace event to 54b8455be9505c2cb0cf5c26bb86739c236471aa
    @targos
    targos committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    1399906 View commit details
    Browse the repository at this point in the history

  2. tools: do not disable ICU's transliteration 

    V8 needs it for case conversion.
Ref: https://codereview.chromium.org/1812673005
    @targos
    targos committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    8c13873 View commit details
    Browse the repository at this point in the history

  3. build: update V8 gypfile paths 

    The location of various gypfiles has changed in V8 5.2.
    @targos
    targos committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    2d7abd9 View commit details
    Browse the repository at this point in the history

  4. v8: warn in Template::Set() on improper use 

    The next major release will make it a fatal error to use non-primitive
values in function templates and object templates.

Print a warning that includes the C and JS stack trace to tell people to
upgrade their add-ons.  The C stack trace is only printed on platforms
that support it (the BSDs, OS X and Linux+glibc.)

The warning can be disabled with the new `--nowarn_template_set` flag.

Refs: nodejs#6216
PR-URL: nodejs#6277
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis @targos
    bnoordhuis authored and targos committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    e19f71b View commit details
    Browse the repository at this point in the history

  5. deps: cherry-pick 2b4c9c1 from v8 upstream 

    Original commit message:

S390:Update inline asm constraint in test-platform
The GetStackPointer() routine in test-platform uses an inline
assembly code to store the current stack pointer value into a static
variable sp_addr.  The existing asm code for S390 uses an ST/STG
instruction, with the memory operand associated with the general ('=g')
constraint to sp_addr.

On GCC 4.8.5, the GCC compiler got confused and treated sp_addr as
an integer operand instead of memory operand, resulting in a store
being emitted that writes to an invalid meory location.

Given the specific store instructions being inlined here, we should
restict the sp_addr operand to explicitly be a memory operand using '=m'
instead of '=g'.

R=bmeurer@chromium.org,jkummerow@chormium.org,rmcilroy@chromium.org,yangguo@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2158523002
Cr-Commit-Position: refs/heads/master@{nodejs#37809}

Fixes: nodejs#7659
PR-URL: nodejs#7771
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
    @joransiu @targos
    joransiu authored and targos committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    9225758 View commit details
    Browse the repository at this point in the history

  6. temporarily remove proxy test

    @targos
    targos committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    c3d8bcf View commit details
    Browse the repository at this point in the history

  7. attempt to fix freebsd compilation

    @targos
    targos committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    406dd07 View commit details
    Browse the repository at this point in the history

  8. remove crash instrumentation to fix smartos64 build

    @targos
    targos committed Jul 26, 2016
    Configuration menu
    Copy the full SHA
    e6ac388 View commit details
    Browse the repository at this point in the history