Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: don't override all internal repl defaults #7826

Merged
merged 2 commits into from
Aug 8, 2016
Merged

repl: don't override all internal repl defaults #7826

merged 2 commits into from
Aug 8, 2016

Commits on Aug 8, 2016

  1. test: allow globals to be whitelisted 

    This commit adds a function to test/common.js that allows
additional global variables to be whitelisted in a test.

PR-URL: nodejs#7826
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Aug 8, 2016
    Configuration menu
    Copy the full SHA
    f18b1c9 View commit details
    Browse the repository at this point in the history

  2. repl: don't override all internal repl defaults 

    The createInternalRepl() module accepts an options object as an
argument. However, if one is provided, it overrides all of the
default options. This commit applies the options object to the
defaults, only changing the values that are explicitly set.

PR-URL: nodejs#7826
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Aug 8, 2016
    Configuration menu
    Copy the full SHA
    2d4a521 View commit details
    Browse the repository at this point in the history