Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert fs changes #7846

Closed
wants to merge 1 commit into from
Closed

Commits on Aug 4, 2016

  1. Revert "fs: make callback mandatory to all async functions"

    This reverts commit 9359de9.
    
    Original Commit Message:
    
        The "fs" module has two functions called `maybeCallback` and
        `makeCallback`, as of now.
    
        The `maybeCallback` creates a default function to report errors, if the
        parameter passed is not a function object. Basically, if the callback
        is omitted in some cases, this function is used to create a default
        callback function.
    
        The `makeCallback`, OTOH, creates a default function only if the
        parameter passed is `undefined`, and if it is not a function object it
        will throw an `Error`.
    
        This patch removes the `maybeCallback` function and makes the callback
        function argument mandatory for all the async functions.
    
        PR-URL: nodejs#7168
        Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Myles Borins authored and MylesBorins committed Aug 4, 2016
    Configuration menu
    Copy the full SHA
    94e7af6 View commit details
    Browse the repository at this point in the history