doc: add npm link and cleanup Readme #7894
Conversation
|
LGTM (and for whoever lands this, there already are reviews in #7769) |
|
LGTM Just an fyi @oscarmorrison ... it most cases, multiple commits in a single PR can be "squashed" into a single commit without requiring a new PR to be opened. This can be done using |
| * [Website][] | ||
| * [Contributing to the project][] | ||
| * [nodejs.org](https://nodejs.org/) | ||
| * Contributing: [CONTRIBUTING.md](./CONTRIBUTING.md) |
There was a problem hiding this comment.
This change would leave two dead links at the bottom of the page. I'd prefer if you could just update the links on the bottom instead. The relative link to CONTRIBUTING.md could be problematic, how about just adding a link to the file on master instead?
|
I agree with @yorkie and @silverwind about the changed links. I think it would be better to just define them at the bottom. @oscarmorrison can you please rebase this against master? Thanks! |
|
@lpinca You think I would remove the https://www.npmjs.com link? |
|
No, I don't think so I would keep it for now. |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999 to
83c7a88
Compare
oscarmorrison
force-pushed
the
patch-2
branch
2 times, most recently
from
e8e52c5 to
590bc47
Compare
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine. Node.js | |||
| uses an event-driven, non-blocking I/O model that makes it lightweight and | |||
| efficient. The Node.js package ecosystem, npm, is the largest ecosystem of open | |||
| efficient. The Node.js package ecosystem, [npm][], is the largest ecosystem of open | |||
There was a problem hiding this comment.
Nit: this line is too long, can you please wrap it a 80 chars? Thanks.
missing the npm link in the readme. wrap line
oscarmorrison
force-pushed
the
patch-2
branch
from
abcd893 to
ff9d5ec
Compare
|
Thanks @lpinca i have made change and squashed commit. |
|
Thanks! Landed in d548d28. |
PR-URL: #7894 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #7894 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #7894 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #7894 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #7894 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #7894 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Note: this is a cleaned (single commit) of the PR #7769
Checklist
Affected core subsystem(s)
doc
Description of change
README.md missing npm link
formatted links for consistency and readability