Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix cluster message event docs #8017

Closed
wants to merge 1 commit into from
Closed

doc: fix cluster message event docs #8017

wants to merge 1 commit into from

Conversation

zbjornson
Copy link
Contributor

  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc for cluster

Description of change
  • cluster "message" is emitted when master, not worker, receives a message from a worker.

Fixes #7997.

@zbjornson
doc: fix cluster message event docs
a75022a 
* cluster "message" is emitted when master, not worker, receives a message from a worker.

Fixes nodejs#7997.
@nodejs-github-bot nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations. labels Aug 8, 2016
@zbjornson zbjornson mentioned this pull request Aug 8, 2016
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Aug 8, 2016

LGTM

2 similar comments
@mscdex
Copy link
Contributor

mscdex commented Aug 8, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Aug 9, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Aug 10, 2016

Thanks, landed in e925b62.

@cjihrig cjihrig closed this Aug 10, 2016
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@zbjornson @cjihrig
doc: fix cluster message event docs
e925b62 
Fixes: #7997
PR-URL: #8017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 10, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@zbjornson @cjihrig
doc: fix cluster message event docs
96d15e2 
Fixes: #7997
PR-URL: #8017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@zbjornson
doc: fix cluster message event docs
0f9d7fd 
Fixes: #7997
PR-URL: #8017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@zbjornson @rvagg
doc: fix cluster message event docs
c39357d 
Fixes: #7997
PR-URL: #8017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@zbjornson @MylesBorins
doc: fix cluster message event docs
f1e14e4 
Fixes: #7997
PR-URL: #8017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zbjornson @cjihrig @mscdex @jasnell @MylesBorins @nodejs-github-bot