test: exclude tests for AIX #8076
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM CI: https://ci.nodejs.org/job/node-test-pull-request/3641/ As with #8065 , I believe this can be landed quickly. cc @nodejs/lts |
|
LGTM |
| @@ -31,3 +31,14 @@ test-tls-connect-address-family : PASS,FLAKY | |||
| # regressions until this work is complete | |||
| [$system==aix] | |||
| test-fs-watch-enoent : FAIL, PASS | |||
| # disable so we don't get failures now that AIX has been | |||
There was a problem hiding this comment.
Can you capitalize "disable".
|
LGTM |
MylesBorins
force-pushed
the
v4.x-staging
branch
from
810f29f to
9308205
Compare
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced.
mhdawson
added a commit
that referenced
this pull request
Aug 25, 2016
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: #8076 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed as: 4bfb247 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 28, 2016
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: #8076 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: #8076 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Exclude tests for AIX in 4.x stream now that its been added to regular regression runs. This will avoid known failures from making the build look RED while also being able to catch any new regressions if they are introduced. PR-URL: #8076 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
exclude tests for AIX in 4.x stream now that
its been added to regular regression runs. This
will avoid known failures from making the build
look RED while also being able to catch any
new regressions if they are introduced.