-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: updating references to the old node.js file #8092
Conversation
The node.js script was renamed to bootstrap_node.js as part of 81b6882. When I did this I missed several comments in src/node.cc that referred to the old file name. This commit updates the comments to refer to bootstrap_node.js and correct the path to this file where used. It also moves a comment that seems to have drifted in the file.
|
||
// We start the process this way in order to be more modular. Developers | ||
// who do not like how 'src/node.js' setups the module system but do like | ||
// Node's I/O bindings may want to replace 'f' with their own function. | ||
// who do not like how 'lib/internal/bootstrap_node.js' setups the module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps putting the full path here is unnecessary since the filename itself isn't ambiguous?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll remove the path.
CHECK(f_value->IsFunction()); | ||
Local<Function> f = Local<Function>::Cast(f_value); | ||
|
||
// Now we call 'f' with the 'process' variable that we've built up with | ||
// all our bindings. Inside node.js we'll take care of assigning things to | ||
// their places. | ||
// all our bindings. Inside bootstrap_node.js we'll take care of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "internal/bootstrap_node.js".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary to put the full path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
lgtm |
LGTM |
1 similar comment
LGTM |
The node.js script was renamed to bootstrap_node.js as part of 81b6882. Several comments were missed in src/node.cc that referred to the old file name. This commit updates the comments to refer to bootstrap_node.js and correct the path to this file where used. It also moves a comment that seems to have drifted in the file. PR-URL: #8092 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 0441f2a |
The node.js script was renamed to bootstrap_node.js as part of 81b6882. Several comments were missed in src/node.cc that referred to the old file name. This commit updates the comments to refer to bootstrap_node.js and correct the path to this file where used. It also moves a comment that seems to have drifted in the file. PR-URL: #8092 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
src
Description of change
The node.js script was renamed to bootstrap_node.js as part of
81b6882. When I did this I missed
several comments in src/node.cc that referred to the old file name.
This commit updates the comments to refer to bootstrap_node.js and
correct the path to this file where used.
It also moves a comment that seems to have drifted in the file.