-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release announcement instruction for Twitter #8126
Update release announcement instruction for Twitter #8126
Conversation
We should just have a bot linked to twitter that we have verified keys to to produce a post... some of us could probably make that |
LGTM |
+1 to having some automation around this. It ought to be possible for release team members to simply be able to fill in a form (or command line tool) to do this rather than depending on email... with the understanding, of course, that the tweet would still need to be reviewed before it actually goes out. |
LGTM. I'd be up for helping with automating |
/cc @nodejs/release |
Perhaps a job for our gh-bot? |
Nit: The first line of the commit message should start with |
Text changes LGTM. |
I would assume that we will send an email to that same address in the event something holds a release up? |
@evanlucas Absolutely. @thealphanerd and I had chatted a bit about if there's a problem with a build there can be delays, so we're happy to be watching out for those emails too. |
cc340e4
to
5a84890
Compare
@Trott amended message 🎉 |
PR-URL: #8126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Landed in e1c042e. Thanks @hackygolucky ! |
PR-URL: #8126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8126 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Checklist
Affected core subsystem(s)
N/a
Description of change
This change updates the instructions for release announcements to allow for the official @nodejs account to tweet releases instead of retweeting.
Future iterations of this can include automation upon blog post publishing, but this is to help in the short term so that we're coordinating communications manually with those who have access to the Twitter account, instead of not at all.