Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release announcement instruction for Twitter #8126

Conversation

hackygolucky
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

N/a

Description of change

This change updates the instructions for release announcements to allow for the official @nodejs account to tweet releases instead of retweeting.

Future iterations of this can include automation upon blog post publishing, but this is to help in the short term so that we're coordinating communications manually with those who have access to the Twitter account, instead of not at all.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 16, 2016
@Fishrock123
Copy link
Contributor

We should just have a bot linked to twitter that we have verified keys to to produce a post... some of us could probably make that

@jasnell
Copy link
Member

jasnell commented Aug 16, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Aug 16, 2016

+1 to having some automation around this. It ought to be possible for release team members to simply be able to fill in a form (or command line tool) to do this rather than depending on email... with the understanding, of course, that the tweet would still need to be reviewed before it actually goes out.

@MylesBorins
Copy link
Contributor

LGTM. I'd be up for helping with automating

@MylesBorins
Copy link
Contributor

/cc @nodejs/release

@MylesBorins MylesBorins added the meta Issues and PRs related to the general management of the project. label Aug 16, 2016
@jbergstroem
Copy link
Member

Perhaps a job for our gh-bot?

@Trott
Copy link
Member

Trott commented Aug 16, 2016

Nit: The first line of the commit message should start with doc:.

@Trott
Copy link
Member

Trott commented Aug 16, 2016

Text changes LGTM.

@evanlucas
Copy link
Contributor

I would assume that we will send an email to that same address in the event something holds a release up?

@hackygolucky
Copy link
Contributor Author

@evanlucas Absolutely. @thealphanerd and I had chatted a bit about if there's a problem with a build there can be delays, so we're happy to be watching out for those emails too.

@hackygolucky hackygolucky force-pushed the update-twitter-announce-releases branch from cc340e4 to 5a84890 Compare August 16, 2016 21:45
@hackygolucky
Copy link
Contributor Author

@Trott amended message 🎉

jasnell pushed a commit that referenced this pull request Aug 18, 2016
PR-URL: #8126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell
Copy link
Member

jasnell commented Aug 18, 2016

Landed in e1c042e. Thanks @hackygolucky !

@jasnell jasnell closed this Aug 18, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
PR-URL: #8126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
PR-URL: #8126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
PR-URL: #8126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
PR-URL: #8126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
PR-URL: #8126
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants