test: confirm that assert truncates long values #8134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
assert
`assert` has code to truncate values that take more than 128 characters to display. Add a test for this functionality, as the code is not currently exercised in the existing tests.
Trott
force-pushed
the
testnotdeepstrictequal
branch
from
2acdb1d
to
e72e3e2
Compare
|
LGTM |
|
Out of curiosity, are you using some kind of code coverage tool ? |
|
@targos asked:
I'm using @addaleax's work: https://node-core-coverage.addaleax.net/ |
| // Long values should be truncated for display. | ||
| assert.throws(() => { | ||
| assert.strictEqual('A'.repeat(1000), ''); | ||
| }, new RegExp(`'${'A'.repeat(127)} === ''`)); |
There was a problem hiding this comment.
Could you include some $ and ^ checking in here?
|
LGTM with a comment. |
|
LGTM |
Trott
force-pushed
the
testnotdeepstrictequal
branch
from
e252624
to
94ad665
Compare
|
Added stricter RegExp per @cjihrig. CI again: https://ci.nodejs.org/job/node-test-pull-request/3713/ |
|
still LGTM |
Trott
force-pushed
the
testnotdeepstrictequal
branch
from
94ad665
to
e72e3e2
Compare
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 19, 2016
`assert` has code to truncate values that take more than 128 characters to display. Add a test for this functionality, as the code is not currently exercised in the existing tests. PR-URL: nodejs#8134 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in a0971b7 |
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
`assert` has code to truncate values that take more than 128 characters to display. Add a test for this functionality, as the code is not currently exercised in the existing tests. PR-URL: #8134 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
`assert` has code to truncate values that take more than 128 characters to display. Add a test for this functionality, as the code is not currently exercised in the existing tests. PR-URL: #8134 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
`assert` has code to truncate values that take more than 128 characters to display. Add a test for this functionality, as the code is not currently exercised in the existing tests. PR-URL: #8134 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
`assert` has code to truncate values that take more than 128 characters to display. Add a test for this functionality, as the code is not currently exercised in the existing tests. PR-URL: #8134 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test assert
Description of change
asserthas code to truncate values that take more than 128 charactersto display. Add a test for this functionality, as the code is not
currently exercised in the existing tests.