Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: correct argument type for process.cpuUsage #8158

Closed
wants to merge 1 commit into from
Closed

doc: correct argument type for process.cpuUsage #8158

wants to merge 1 commit into from

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Aug 18, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Correct type of argument passed to process.cpuUsage

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Aug 18, 2016
@evanlucas
Copy link
Contributor

LGTM. Thanks!

@cjihrig
Copy link
Contributor

cjihrig commented Aug 18, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Aug 18, 2016

LGTM

@addaleax
Copy link
Member

LGTM, landing…

@addaleax
Copy link
Member

Landed in 1df3797, thanks for the correction!

@addaleax addaleax closed this Aug 22, 2016
addaleax pushed a commit that referenced this pull request Aug 22, 2016
@SimenB @addaleax
doc: correct argument type for process.cpuUsage
1df3797 
PR-URL: #8158
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@SimenB SimenB deleted the patch-1 branch August 22, 2016 09:50
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@SimenB @evanlucas
doc: correct argument type for process.cpuUsage
7f34cc3 
PR-URL: #8158
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SimenB @evanlucas @cjihrig @jasnell @addaleax @MylesBorins @nodejs-github-bot