Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_main: use ERROR_EXE_MACHINE_TYPE_MISMATCH instead 1 as exit code #8204

Closed
wants to merge 1 commit into from
Closed

node_main: use ERROR_EXE_MACHINE_TYPE_MISMATCH instead 1 as exit code #8204

wants to merge 1 commit into from

Commits on Aug 29, 2016

  1. src,win: use correct exit code in old versions 

    If `IsWindows7OrGreater()` returns `false`, the Node.js program should
exit with a more specific code ERROR_EXE_MACHINE_TYPE_MISMATCH instead
the code 0x1(ERROR_INVALID_FUNCTION)

PR-URL: nodejs#8204
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @yorkie
    yorkie committed Aug 29, 2016
    Configuration menu
    Copy the full SHA
    a080f1a View commit details
    Browse the repository at this point in the history