Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add Myles Borins to the CTC #8260

Closed
wants to merge 1 commit into from
Closed

doc: add Myles Borins to the CTC #8260

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Aug 24, 2016

This was voted on the CTC meeting this week so this PR just needs review, @thealphanerd can you check pls?

Congrats btw!

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 24, 2016
@ChALkeR
Copy link
Member

ChALkeR commented Aug 24, 2016 •
edited
Loading

LGTM

Upd: yes, with removing the duplicate entry under Collaborators as @addaleax noted.

@addaleax
Copy link
Member

I think Myles should be moved from the Collaborators list to the CTC members list, LGTM with that (and if @thealphanerd is happy with this, of course 😄)

And yep, congratulations!

@jasnell
Copy link
Member

jasnell commented Aug 24, 2016

+1 to the nit from @addaleax ... otherwise LGTM

@MylesBorins
Copy link
Contributor

thank you all so much. very honored to be included!

On Wed, Aug 24, 2016, 9:03 PM James M Snell notifications@github.com
wrote:

+1 to the nit from @addaleax https://github.com/addaleax ... otherwise
LGTM

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8260 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV-sZHhNAydx0sJiVxXP70HY2Lce2ks5qjLGugaJpZM4JsccE
.

@MylesBorins
Copy link
Contributor

also, lgtm

@jasnell
Copy link
Member

jasnell commented Aug 25, 2016

pretty certain this one doesn't need the 48 hours... landing

@jasnell
Copy link
Member

jasnell commented Aug 25, 2016 •
edited by Trott
Loading

Landed in 36086b2

@jasnell jasnell closed this Aug 25, 2016
jasnell pushed a commit that referenced this pull request Aug 25, 2016
@rvagg @jasnell
doc: add Myles Borins to the CTC
2367e6c 
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 25, 2016

Looks like this was re-landed in 2367e6c with a force push.

@jasnell
Copy link
Member

jasnell commented Aug 25, 2016

yep... accidentally botched the first one... thanks for updating the pr

@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Closed
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
@rvagg @Fishrock123
doc: add Myles Borins to the CTC
ab0889a 
PR-URL: nodejs#8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
@rvagg @Fishrock123
doc: add Myles Borins to the CTC
260663f 
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@rvagg
doc: add Myles Borins to the CTC
3709dbf 
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@rvagg
doc: add Myles Borins to the CTC
ade85c6 
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
rvagg added a commit that referenced this pull request Oct 18, 2016
@rvagg
doc: add Myles Borins to the CTC
9de40cc 
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@rvagg @MylesBorins
doc: add Myles Borins to the CTC
0b60563 
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rvagg @ChALkeR @addaleax @jasnell @MylesBorins @Trott @nodejs-github-bot