Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix depenencies on AIX #8272

Closed
wants to merge 1 commit into from
Closed

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Aug 25, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

Description of change

addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to
node_exp target to avoid this.
this.

Fixes: #8239

addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 25, 2016
@mhdawson mhdawson self-assigned this Aug 25, 2016
@mhdawson
Copy link
Member Author

mhdawson commented Aug 25, 2016

I'm assuming we can land this quickly as it resolves a regular issue in the CI, is low risk, only affects AIX and should not be controversial in any way.

@mhdawson
Copy link
Member Author

@bnoordhuis, @Trott can you take a look and L.G.T.M, if appropriate

@Trott
Copy link
Member

Trott commented Aug 25, 2016

I'm assuming we can land this quickly as it resolves a regular issue in the CI, is low risk, only affects AIX and should not be controversial in any way.

Agreed that we should land it quickly.

LGTM. (My gyp knowledge is limited but this is also a very limited change.)

@bnoordhuis
Copy link
Member

LGTM

@addaleax
Copy link
Member

Commit message typo: depenencies

LGTM

@jbergstroem
Copy link
Member

LGTM

@Trott
Copy link
Member

Trott commented Aug 25, 2016

Commit message typo: depenencies

@addaleax You seem to catch typos in commit messages more than anyone else (probably more than everyone else combined), which I really appreciate. 🎉

@jasnell
Copy link
Member

jasnell commented Aug 25, 2016

You mean we're actually supposed to be reading the commit messages!? ;-)

@mhdawson
Copy link
Member Author

mhdawson added a commit that referenced this pull request Aug 25, 2016
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@mhdawson
Copy link
Member Author

Landed as 063d14e

@mhdawson mhdawson closed this Aug 25, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: nodejs#8239
PR-URL: nodejs#8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
@mhdawson mhdawson deleted the aixaddon branch March 15, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants